summaryrefslogtreecommitdiff
path: root/lib/kDL.ml
diff options
context:
space:
mode:
authortoastal2026-04-15 01:43:05 +0000
committerยท๐‘‘๐‘ด๐‘•๐‘‘๐‘ฉ๐‘ค2026-04-15 01:43:05 +0000
commit9b65a20925349dbdc5919041d81cbd12ad8facf1 (patch)
tree81d98cf0191e890b2af523d69a2d2849b71157de /lib/kDL.ml
parent2de700733370b22797ff71667f68c119951c3194 (diff)
downloadnixtaml-9b65a20925349dbdc5919041d81cbd12ad8facf1.tar
nixtaml-9b65a20925349dbdc5919041d81cbd12ad8facf1.tar.gz
nixtaml-9b65a20925349dbdc5919041d81cbd12ad8facf1.tar.bz2
nixtaml-9b65a20925349dbdc5919041d81cbd12ad8facf1.tar.lz
nixtaml-9b65a20925349dbdc5919041d81cbd12ad8facf1.tar.xz
nixtaml-9b65a20925349dbdc5919041d81cbd12ad8facf1.tar.zst
nixtaml-9b65a20925349dbdc5919041d81cbd12ad8facf1.zip
Phase 1: Fix security vulnerabilities and error handling
- Fix command injection in editor.ml using Filename.quote - Change KDL.of_flow to return Result instead of failwith - Update manifest.ml to handle new Result type Security: Prevents shell injection when opening files with malicious filenames containing shell metacharacters. Error handling: KDL parsing errors now return Result type instead of crashing with failwith.
Diffstat (limited to 'lib/kDL.ml')
-rw-r--r--lib/kDL.ml5
1 files changed, 3 insertions, 2 deletions
diff --git a/lib/kDL.ml b/lib/kDL.ml
index 550c26f..a00d1ff 100644
--- a/lib/kDL.ml
+++ b/lib/kDL.ml
@@ -11,8 +11,9 @@ let of_flow flow =
(fun buf -> Eio.Buf_read.take_all buf |> Kdl.of_string)
~max_size: max_int
flow
+ |> Result.ok
with
- | exn -> failwith (Printexc.to_string exn)
+ | Kdl.Parse_error (msg, _) -> Error (`ParseError msg)
let to_flow flow doc =
Eio.Buf_write.with_flow flow @@ fun buf ->
@@ -40,7 +41,7 @@ module L = KDL_lens_result
module Valid = struct
type err = [
| L.lerr
- | `ParseError of Kdl.error
+ | `ParseError of string
| `OneRequired of string list
| `OnlyOneOf of string list
| `InvalidLatestCmd of string